Update errorProneVersion to v2.31.0 (#6642)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jack Berg <[email protected]>
open-telemetry · Aug 30, 2024 · 37e35b2 · 37e35b2
1 parent 365fe8a
commit 37e35b2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/dependencyManagement/build.gradle.kts b/dependencyManagement/build.gradle.kts
@@ -25,7 +25,7 @@ val DEPENDENCY_BOMS = listOf(
 )
 
 val autoValueVersion = "1.11.0"
-val errorProneVersion = "2.29.2"
+val errorProneVersion = "2.31.0"
 val jmhVersion = "1.37"
 // Mockito 5.x.x requires Java 11 https://github.com/mockito/mockito/releases/tag/v5.0.0
 val mockitoVersion = "4.11.0"

diff --git a/...rc/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/RateLimitingSampler.java b/...rc/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/RateLimitingSampler.java
@@ -21,6 +21,7 @@
 import java.text.DecimalFormat;
 import java.text.DecimalFormatSymbols;
 import java.util.List;
+import java.util.Locale;
 
 /**
  * {@link RateLimitingSampler} sampler uses a leaky bucket rate limiter to ensure that traces are
@@ -73,7 +74,7 @@ public String toString() {
   }
 
   private static String decimalFormat(double value) {
-    DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance();
+    DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance(Locale.ROOT);
     decimalFormatSymbols.setDecimalSeparator('.');
 
     DecimalFormat decimalFormat = new DecimalFormat("0.00", decimalFormatSymbols);

diff --git a/...trics/src/main/java/io/opentelemetry/sdk/metrics/internal/debug/StackTraceSourceInfo.java b/...trics/src/main/java/io/opentelemetry/sdk/metrics/internal/debug/StackTraceSourceInfo.java
@@ -5,6 +5,8 @@
 
 package io.opentelemetry.sdk.metrics.internal.debug;
 
+import java.util.Locale;
+
 /** Diagnostic information derived from stack traces. */
 final class StackTraceSourceInfo implements SourceInfo {
 
@@ -19,7 +21,7 @@ public String shortDebugString() {
     if (stackTraceElements.length > 0) {
       for (StackTraceElement e : stackTraceElements) {
         if (isInterestingStackTrace(e)) {
-          return String.format("%s:%d", e.getFileName(), e.getLineNumber());
+          return String.format(Locale.ROOT, "%s:%d", e.getFileName(), e.getLineNumber());
         }
       }
     }

diff --git a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/samplers/TraceIdRatioBasedSampler.java b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/samplers/TraceIdRatioBasedSampler.java
@@ -13,6 +13,7 @@
 import java.text.DecimalFormat;
 import java.text.DecimalFormatSymbols;
 import java.util.List;
+import java.util.Locale;
 import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 
@@ -112,7 +113,7 @@ private static long getTraceIdRandomPart(String traceId) {
   }
 
   private static String decimalFormat(double value) {
-    DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance();
+    DecimalFormatSymbols decimalFormatSymbols = DecimalFormatSymbols.getInstance(Locale.ROOT);
     decimalFormatSymbols.setDecimalSeparator('.');
 
     DecimalFormat decimalFormat = new DecimalFormat("0.000000", decimalFormatSymbols);