chore: update grpc-gateway to downgrade minimum go #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alternatively we could wait until the next release of the library |
|
Missing CI workflows. |
codeboten
added a commit
to codeboten/opentelemetry-go
that referenced
this pull request
Dec 17, 2024
This is pulling in a change to opentelemetry-proto-go that allows us to set the minimum go version back down to 1.22.0. This depends on open-telemetry/opentelemetry-proto-go#224 Signed-off-by: Alex Boten <[email protected]>
nvm, wrong repo 🤦 |
MrAlias
approved these changes
Dec 18, 2024
Merged
This pulls in the version of grpc-gateway/v2 in main to downgrade the minimum version of go required. Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/bump-down-go-1.22
branch
from
2cc3669 to
a8ddbe6
Compare
XSAM
approved these changes
Dec 19, 2024
codeboten
added a commit
to codeboten/opentelemetry-go
that referenced
this pull request
Dec 19, 2024
This is pulling in a change to opentelemetry-proto-go that allows us to set the minimum go version back down to 1.22.0. This depends on open-telemetry/opentelemetry-proto-go#224 Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the version of grpc-gateway/v2 in main to downgrade the minimum version of go required.