Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add EoL Post Install Messages #1264

Merged
merged 3 commits into from
Nov 26, 2024
Merged

chore: Add EoL Post Install Messages #1264

merged 3 commits into from
Nov 26, 2024

Conversation

arielvalentin
Copy link
Collaborator

@arielvalentin arielvalentin commented Nov 24, 2024 •
edited
Loading

We want to give folks a heads up that we are going to stop supporting EoL versions of Ruby and Rails.

This prints a message at install time rather than creating noisy deprecation warnings that appear at runtime.

What you will see when you install the gems:

Ruby 3.0 has reached EoL 2024-04-23. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Ruby 3.0 after 2025-01-15. Please upgrade to Ruby to continue receiving updates.

Rails 6.1 has reached EoL 2024-10-01. OTel Ruby Contrib gems will no longer accept new features or bug fixes for Rails 6.1 after 2025-01-15. Please upgrade to Rails to continue receiving updates.
Successfully installed opentelemetry-instrumentation-all-0.69.0

See #1223
See #1211

@arielvalentin arielvalentin self-assigned this Nov 24, 2024
kaylareopelle
kaylareopelle reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this together!

POST_INSTALL_MESSAGE Outdated Show resolved Hide resolved
instrumentation/all/opentelemetry-instrumentation-all.gemspec Show resolved Hide resolved
@arielvalentin @kaylareopelle
Update POST_INSTALL_MESSAGE
0ecd3f5 
Co-authored-by: Kayla Reopelle <[email protected]>
@arielvalentin arielvalentin merged commit aae89d7 into open-telemetry:main Nov 26, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

Assignees

@arielvalentin arielvalentin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielvalentin @kaylareopelle