Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update instrumentation pg to support merge statements #1317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ericmustin
Copy link
Contributor

Summary

In postgres15+, the MERGE statement was added

https://www.postgresql.org/docs/current/sql-commands.html
https://www.postgresql.org/docs/current/sql-merge.html

we don't support it currently in our hard coded list of pg sql command constants(which was contributed before MERGE was added, iiuc), which results in missing db.operation attributes and db.statement attributes that look like ; on pg spans for merge statements, which isn't very useful.

This PR adds MERGE to our constants list, and also cleans up some duplicate entries :)

Notes

This was surfaced in cncf slack, i think my tests should pass but letting the ci do the work.

Hope everyone is doing well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant