fix: Allow overlapping context scopes #2378
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1887
This PR is fully functional, but not complete with edge case checks, tests and comments. It's ment as a basis for discussions.
Changes
This PR changes the single current
Context
to a more robust stack that is resilient to out of order and overlappingContext
scopes. This robustness is needed to be able to support better interop with tokio-rs/tracing.There are some
context_attach
benchmarks added, and this implementation performs the same or between 3-17% faster than the old one (while maintaining a working context state).As for the
context
benchmarks inopentelemetry-sdk
, this implementation performs the same except for thecontext/is_sampled/?/alt
variants where it is 6-7% slower. I haven't dug into this too much at this point.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes