Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary featureflag for eventname #2480

Merged

Conversation

cijothomas
Copy link
Member

Fully fixes #2410 by removing feature flags that are no longer relevant.

@cijothomas cijothomas requested a review from a team as a code owner December 27, 2024 02:24
@cijothomas cijothomas requested a review from Copilot December 27, 2024 02:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • opentelemetry-proto/Cargo.toml: Evaluated as low risk
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.2%. Comparing base (e378bc8) to head (4719b0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2480   +/-   ##
=====================================
  Coverage   77.2%   77.2%           
=====================================
  Files        124     124           
  Lines      23051   23043    -8     
=====================================
  Hits       17800   17800           
+ Misses      5251    5243    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. nit - There is some reference of this flag in stdout exporter too (ref - https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-rust%20populate-logs-event-name&type=code), good to remove it here or separately.

@cijothomas cijothomas merged commit 8fde6eb into open-telemetry:main Dec 27, 2024
21 checks passed
@cijothomas cijothomas deleted the cijothomas/cleanup-eventname branch December 27, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting EventName
2 participants