Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system version comparison in iOS and watchOS #487

Closed
wants to merge 2 commits into from

Conversation

nachoBonafonte
Copy link
Member

@nachoBonafonte nachoBonafonte commented Nov 30, 2023

Fix system version comparison in iOS and watchOS. It was failing when version included more than two numbers.

Fixes #483

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7426e4) 66.51% compared to head (a27508d) 66.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   66.51%   66.47%   -0.05%     
==========================================
  Files         335      335              
  Lines       14327    14325       -2     
==========================================
- Hits         9530     9522       -8     
- Misses       4797     4803       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nachoBonafonte
Copy link
Member Author

This solution is wrong, don't merge

@nachoBonafonte nachoBonafonte deleted the main branch December 1, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is async-based method URLSession.shared.data supported?
1 participant