Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instrumenting async-await network calls when running in certain system versions #488

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

nachoBonafonte
Copy link
Member

URLSessionInstrumentation version check was wrong and it made fail instrumenting async-await network calls when running in certain system versions.

Fixes #483

…strumenting async-await network calls when running in certain system versions
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f9704c1) 66.47% compared to head (7cd1c7b) 66.43%.

Files Patch % Lines
...ntation/URLSession/URLSessionInstrumentation.swift 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   66.47%   66.43%   -0.04%     
==========================================
  Files         335      335              
  Lines       14327    14302      -25     
==========================================
- Hits         9524     9502      -22     
+ Misses       4803     4800       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nachoBonafonte nachoBonafonte merged commit 10563f4 into open-telemetry:main Dec 4, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is async-based method URLSession.shared.data supported?
2 participants