Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small Style Changes to the UI #108

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Tysonpower
Copy link

Description:

Made some small padding changes etc. to make the UI look a bit nicer.

Checklist:

  • [x ] The code change is tested and works locally.

@rsjudka
Copy link
Contributor

rsjudka commented Dec 26, 2021

you mind adding some screenshots of the changes? don't have access to my PC but if they look good i can merge it in

@Tysonpower
Copy link
Author

here is a quick screenshot, added padding at the top tab bar as well as the file selector

image

@Tysonpower
Copy link
Author

@rsjudka please merge

@rsjudka
Copy link
Contributor

rsjudka commented Jan 7, 2022

oh sorry thought i responded!

im okay with the fixes to the list widget, but the padding for the tab bar might be a bit much (especially for those with lower resolutions - sorry for the callout but @icecube45 what do you think of that?)

@icecube45
Copy link
Member

The vertical padding of the tab bar? Agreed on it being excessive. It's about a quarter (maybe a fifth) of the vertical display on the resolution I'm working with, pretty big increase from previous.
image

I'll try to test it on the actual car display though, to see how it works out on there.

@Tysonpower
Copy link
Author

what size of car display is that? That is really really really small :)

@akhil11naseem
Copy link

I am building this for my motorcycle to replace mounting my phone on the handlebar. So I am using a small 4.3" 480x800 waveshare display. So excessive padding would make it difficult to use in my use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants