Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OBD2 reading/parsing logic from Vehicle page to dedicated plugin #93

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

egisz
Copy link
Contributor

@egisz egisz commented Aug 10, 2021

Description:

Problem with current vehicle page is that it depends on OBDII protocol and it is not supported on 100% cars.
Even worse, on unsupported vehicles, in order to query OBD2 status, it generates CANbus messages to unsupported canbus frames.

I moved away all canbus/obd2 code to separate vehicle plugin obd2 (plugins/vehicle/obd2). This way if car supports it, user can enable it under plugins.
If not, user can choose from other plugin which can read CANbus messages and provide data to Vehicle page.

Each vehicle plugin can update Vehicle page using new arbiter method void vehicle_update_data(QString gauge_id, int value);

As a bonus I enabled Fuel Consumption gauge, which was disabled in original Vehicle page.

Checklist:

  • The code change is tested and works locally. Note: I don't have OBD2, but tested on my PC using vcan interface, sending packets manually.
  • Testing with OBD2 is required.

@rsjudka
Copy link
Contributor

rsjudka commented Sep 9, 2021

havent gotten a chance to look at it yet... but I think there might be an issue since people use the gauge tab in addition to loading their own plugin

going to think about this a bit more (since right now we only support loading a single plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants