-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OBD2 reading/parsing logic from Vehicle page to dedicated plugin #93
Open
egisz
wants to merge
16
commits into
openDsh:develop
Choose a base branch
from
egisz:vehicle-obd2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subscribe and update gauges listening to arbiter
havent gotten a chance to look at it yet... but I think there might be an issue since people use the gauge tab in addition to loading their own plugin going to think about this a bit more (since right now we only support loading a single plugin) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Problem with current vehicle page is that it depends on OBDII protocol and it is not supported on 100% cars.
Even worse, on unsupported vehicles, in order to query OBD2 status, it generates CANbus messages to unsupported canbus frames.
I moved away all canbus/obd2 code to separate vehicle plugin obd2 (
plugins/vehicle/obd2
). This way if car supports it, user can enable it under plugins.If not, user can choose from other plugin which can read CANbus messages and provide data to Vehicle page.
Each vehicle plugin can update Vehicle page using new arbiter method
void vehicle_update_data(QString gauge_id, int value);
As a bonus I enabled Fuel Consumption gauge, which was disabled in original Vehicle page.
Checklist: