Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpt-3.5-turbo-16k support to ctx len getter #1388

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add gpt-3.5-turbo-16k support to ctx len getter #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions evals/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@


def n_ctx_from_model_name(model_name: str) -> Optional[int]:
"""Returns n_ctx for a given API model name. Model list last updated 2023-06-16."""
"""Returns n_ctx for a given API model name. Model list last updated 2023-10-24."""
# note that for most models, the max tokens is n_ctx + 1
PREFIX_AND_N_CTX: list[tuple[str, int]] = [
("gpt-3.5-turbo-16k-", 16384),
("gpt-3.5-turbo-", 4096),
("gpt-4-32k-", 32768),
("gpt-4-", 8192),
Expand All @@ -52,6 +53,7 @@ def n_ctx_from_model_name(model_name: str) -> Optional[int]:
"text-davinci-002": 4096,
"text-davinci-003": 4096,
"gpt-3.5-turbo": 4096,
"gpt-3.5-turbo-16k": 16384,
"gpt-4": 8192,
"gpt-4-32k": 32768,
"gpt-4-base": 8192,
Expand All @@ -74,13 +76,15 @@ def is_chat_model(model_name: str) -> bool:
if model_name in {"gpt-4-base"}:
return False

CHAT_MODEL_NAMES = {"gpt-3.5-turbo", "gpt-4", "gpt-4-32k"}
CHAT_MODEL_NAMES = {"gpt-3.5-turbo", "gpt-3.5-turbo-16k", "gpt-4", "gpt-4-32k"}

if model_name in CHAT_MODEL_NAMES:
return True

for model_prefix in {"gpt-3.5-turbo-", "gpt-4-", "gpt-4-32k-"}:
for model_prefix in {"gpt-3.5-turbo-", "gpt-4-"}:
if model_name.startswith(model_prefix):
return True

Comment on lines +84 to +87
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to throw an error when there's not an exact match, or be more restrictive about when the prefix matching applies to avoid similar errors in the future.

return False


Expand Down
13 changes: 8 additions & 5 deletions evals/registry_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,25 @@


def test_n_ctx_from_model_name():
assert n_ctx_from_model_name("gpt-3.5-turbo") == 4096
assert n_ctx_from_model_name("gpt-3.5-turbo-0613") == 4096
assert n_ctx_from_model_name("gpt-3.5-turbo-16k") == 16384
assert n_ctx_from_model_name("gpt-3.5-turbo-16k-0613") == 16384
assert n_ctx_from_model_name("gpt-4") == 8192
assert n_ctx_from_model_name("gpt-4-0314") == 8192
assert n_ctx_from_model_name("gpt-4-0613") == 8192
assert n_ctx_from_model_name("gpt-4-32k") == 32768
assert n_ctx_from_model_name("gpt-4-32k-0314") == 32768
assert n_ctx_from_model_name("gpt-4-32k-0613") == 32768


def test_is_chat_model():
assert is_chat_model("gpt-3.5-turbo")
assert is_chat_model("gpt-3.5-turbo-0314")
assert is_chat_model("gpt-3.5-turbo-0613")
assert is_chat_model("gpt-3.5-turbo-16k")
assert is_chat_model("gpt-3.5-turbo-16k-0613")
assert is_chat_model("gpt-4")
assert is_chat_model("gpt-4-0314")
assert is_chat_model("gpt-4-0613")
assert is_chat_model("gpt-4-32k")
assert is_chat_model("gpt-4-32k-0314")
assert is_chat_model("gpt-4-32k-0613")
assert not is_chat_model("text-davinci-003")
assert not is_chat_model("gpt4-base")
assert not is_chat_model("code-davinci-002")
Loading