Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libpcap & OpenSSL and new tree & rsync commands #1076

Closed
wants to merge 1 commit into from

Conversation

abhisit
Copy link
Contributor

@abhisit abhisit commented Dec 6, 2024

  1. Enter to due environment and choose due-onie-build-debian-10
$ due -r 
  1. Build it
    2.1 With machine name "pegatron_dm2118_b"
onie/build-config$ make -j<number of jobs> MACHINEROOT=../machine/pegatron MACHINE=pegatron_dm2118_b all

Full build log for AArch64/pegatron_dm2118_b

user@due-onie-build-debian-10:onie/build-config$ file ../build/pegatron_dm2118_b-r0/sysroot/usr/bin/tree 
../build/pegatron_dm2118_b-r0/sysroot/usr/bin/tree: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 4.19.143, stripped
user@due-onie-build-debian-10:onie/build-config$ file ../build/pegatron_dm2118_b-r0/sysroot/usr/bin/rsync
../build/pegatron_dm2118_b-r0/sysroot/usr/bin/rsync: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 4.19.143, stripped

2.2 With machine name "accton_as4630"

onie/build-config$ make -j<number of jobs> MACHINEROOT=../machine/accton MACHINE=accton_as4630 all

Full build log for x64_64/accton_as4630

user@due-onie-build-debian-10:onie/build-config$ file ../build/accton_as4630-r0/sysroot/usr/bin/tree 
../build/accton_as4630-r0/sysroot/usr/bin/tree: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib/ld64-uClibc.so.0, stripped
user@due-onie-build-debian-10:onie/build-config$ file ../build/accton_as4630-r0/sysroot/usr/bin/rsync
../build/accton_as4630-r0/sysroot/usr/bin/rsync: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld64-uClibc.so.0, stripped
  1. Build with OpenSSL 3.4.0 (optional)
    3.1 With machine name "pegatron_dm2118_b"
    Full build log OpenSSL 3.4.0 for AArch64, target rsync
user@due-onie-build-debian-10:onie/build-config$ OPENSSL_VERSION=3.4.0 make -j<number of jobs> MACHINE=pegatron_dm2118_b MACHINEROOT=../machine/pegatron rsync

3.2 With machine name "accton_as4630"
Full build log OpenSSL 3.4.0 for x86_64, target rsync

user@due-onie-build-debian-10:onie/build-config$ OPENSSL_VERSION=3.4.0 make -j<number of jobs> MACHINEROOT=../machine/accton MACHINE=accton_as4630 rsync

The successor of PR#1070, PR#1071, PR#1072 and PR#1074.

- Fix libpcap creates a wrong destination folder
- Change permission 664 for libpcab.make and tcpdump.make
- Add tree target/command
- Add rsync target/command
- Fix openssl.make does not cross compile for AArch64
- Automatically select libpcap & libopenssl if tcpdump is enabled
- Support OpenSSL version 3.4.0

Signed-off-by: Abhisit Sangjan <[email protected]>
@mshych
Copy link
Collaborator

mshych commented Dec 17, 2024

Hi,
Please make separate pull requests as they were before. Now it's a mix of 4 features:
support openssl 3.4.0,
fix libpcap,
add rsync,
add tree.
What are the real use cases of adding rsync and tree tools?
ONIE should contain just essential tools.
You add them to all builds and not to some specific machine.
I am especially concerned about tree command.
Also repository for this command doesn't look reliable enough.

@abhisit
Copy link
Contributor Author

abhisit commented Dec 19, 2024

Hi Michael,

What are the real use cases of adding rsync and tree tools?

rsync is working over the SSH protocol with integrate checksum, more integrity to copy files/folders and capable to resume at the last point. This command would help to copy the files/folders from/to the ONIE machine.

ONIE should contain just essential tools.
I am especially concerned about tree command.
Also repository for this command doesn't look reliable enough.

tree is not essential tools as we already have ls command.

You add them to all builds and not to some specific machine.

Now, they are new PRs raise up PR#1077, PR#1078, PR#1079 and PR#1080

@abhisit abhisit closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants