This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
Added support for LocalUriInput monitors #380
Merged
qreshi
merged 22 commits into
opendistro-for-elasticsearch:doc-level-alerting-dev
from
AWSHurneyt:doc-level-alerting-dev-localUriInput
Jun 4, 2021
Merged
Added support for LocalUriInput monitors #380
qreshi
merged 22 commits into
opendistro-for-elasticsearch:doc-level-alerting-dev
from
AWSHurneyt:doc-level-alerting-dev-localUriInput
Jun 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r creating ClusterHealth and ClusterStats monitors.
…r creating ClusterHealth and ClusterStats monitors.
…yt/alerting into local-uri-input-monitor-support � Conflicts: � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/settings/SupportedApiSettings.kt
…sed on PR feedback
…t and port is always 9200
…sed on PR feedback
…yt/alerting into local-uri-input-monitor-support � Conflicts: � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunnerIT.kt � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/TestHelpers.kt � core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/LocalUriInput.kt � core/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/LocalUriInputTests.kt
…nd added unit test. Implemented method to redact fields from a response, and added unit tests
…iList using a JSON resource file
…ePath, and javadocs to be more informative.
…xtensions::redactFieldsFromResponse output.
* Add groupByFields to Monitor * Update mappings * Update tests
* Add InputService * Change MonitorRunner to singleton and use register methods for components * Update MonitorRunner to use InputService * Add TriggerService * Update MonitorRunner to use TriggerService * Add AlertService * Update MonitorRunner to use AlertService * Update comment in AlertService
…o-for-elasticsearch/alerting into doc-level-alerting-dev-localUriInput � Conflicts: � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/AlertService.kt � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/AlertingPlugin.kt � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/InputService.kt � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunner.kt � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/TriggerService.kt � alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/Monitor.kt � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/ADTestHelpers.kt � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/TestHelpers.kt � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/action/GetMonitorResponseTests.kt � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/action/IndexMonitorResponseTests.kt � alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/alerts/AlertIndicesIT.kt
lezzago
approved these changes
May 28, 2021
… a call to innerXContent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Original LocalUriInput PR #369
Description of changes:
Merged
LocalUriInput
code with document-level alerting code in preparation for testing.By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.