-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix username suggestions to only show valid usernames #1310
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @milad-emami! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @milad-emami! Just flagging that there are some failing checks here. Please let me know if you have any questions. |
Hi @milad-emami - just checking to see if you're planning to pursue this pull request? If not, we can close for now and reopen in the future if needed. |
Description
This pull request fixes the issue with username suggestions in the registration form. It ensures that only valid usernames (containing letters, numbers, underscores, and hyphens) are displayed as suggestions, preventing invalid usernames from being suggested, especially for users with Persian or Arabic language settings.
How Has This Been Tested?
I tested the changes by entering various usernames to confirm that only valid suggestions appear and that users can click on them to populate the username field.