Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

Include the node10-express-service template #11

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Include the node10-express-service template #11

merged 1 commit into from
Feb 5, 2020

Conversation

burtonr
Copy link
Contributor

@burtonr burtonr commented Feb 5, 2020

Signed-off-by: Burton Rheutan [email protected]

Bringing in the other node10-express template to be included with the other express templates.

This is a cut and copy from the node10-express-service repo. I've also updated the readme to include examples and segregation with the new template.

This will resolve the issue in the original repository: openfaas-incubator/node10-express-service#2

Unfortunately, I'm unable to faas pull this from a branch other than master, but I was able to test it by copying the files and running faas new --list

$ faas new --list
Languages available as templates:
- node10-express
- node10-express-arm64
- node10-express-armhf
- node10-express-service

and created a new function with the newly added template:

$ faas new check --lang node10-express-service
Folder: check created.
  ___                   _____           ____
 / _ \ _ __   ___ _ __ |  ___|_ _  __ _/ ___|
| | | | '_ \ / _ \ '_ \| |_ / _` |/ _` \___ \
| |_| | |_) |  __/ | | |  _| (_| | (_| |___) |
 \___/| .__/ \___|_| |_|_|  \__,_|\__,_|____/
      |_|


Function created in folder: check
Stack file written: check.yml

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 9018824 into openfaas-incubator:master Feb 5, 2020
@burtonr burtonr deleted the add-service-template branch February 5, 2020 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants