Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus scrape annotations to RabbitMQ connector #1232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

welteki
Copy link
Member

@welteki welteki commented Dec 11, 2024

Description

Add Prometheus scrape annotations to RabbitMQ connector to ensure its metrics are scraped by the OpenFaaS Prometheus instance.

Why is this needed?

  • I have raised an issue to propose this change (required)

Expose metrics from the RabbitMQ connector.

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

Deployed the RabbitMQ connector chart and verified the connector showed up as a Prometheus scrape target.
Verified metrics from the connector are available in Prometheus.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant