Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add DB migration library #1275

Merged
merged 5 commits into from
Oct 26, 2023
Merged

feat: add DB migration library #1275

merged 5 commits into from
Oct 26, 2023

Conversation

raphael0202
Copy link
Collaborator

  • add migrate_peewee library to handle DB migrations
  • try with a new product_insight.bounding_box field

@raphael0202 raphael0202 requested a review from a team as a code owner October 25, 2023 12:49
@raphael0202 raphael0202 changed the title feat: add migration library feat: add DB migration library Oct 25, 2023
alexgarel
alexgarel approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to have migrations.

Just added an opinionated comment :-)

gunicorn.py Outdated Show resolved Hide resolved
@raphael0202
fix: improve DB migration
ff70e26 
- apply migrations during deployment instead of automatically at api
  startup
- fix mypy error
- add documentation
- add CLI commands
@raphael0202 raphael0202 merged commit 0a2171d into main Oct 26, 2023
6 checks passed
@raphael0202 raphael0202 deleted the add_migration_lib branch October 26, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@raphael0202 raphael0202

Labels
GitHub Actions insights integration tests robotoff-cli 🧪 tests
Projects
🤖 Artificial Intelligence @ Open Food Facts
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @alexgarel