Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8074092: Newly introduced unnecessary dependencies on internal API in client regtests #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Feb 28, 2024

Apply clean except for jdk/test/javax/swing/JButton/4796987/bug4796987.java, which no longer exists.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8074092 needs maintainer approval

Issue

  • JDK-8074092: Newly introduced unnecessary dependencies on internal API in client regtests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/461/head:pull/461
$ git checkout pull/461

Update a local copy of the PR:
$ git checkout pull/461
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 461

View PR using the GUI difftool:
$ git pr show -t 461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/461.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@yaqsun yaqsun changed the title 8074092: Newly introduced unnecessary dependencies on internal API in client regtests Newly introduced unnecessary dependencies on internal API in client regtests Feb 28, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 28, 2024
@yaqsun yaqsun changed the title Newly introduced unnecessary dependencies on internal API in client regtests Backport 0803af98c7f332e4a8e10239fe00b7dcf58a90e2 Feb 28, 2024
@openjdk openjdk bot changed the title Backport 0803af98c7f332e4a8e10239fe00b7dcf58a90e2 8074092: Newly introduced unnecessary dependencies on internal API in client regtests Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@yaqsun This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 9, 2024
@yaqsun
Copy link
Contributor Author

yaqsun commented Nov 15, 2024

/open

@openjdk openjdk bot reopened this Nov 15, 2024
@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@yaqsun This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant