Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8044051: Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation #610

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Dec 5, 2024

Apply clean. Low risk.


Progress

  • JDK-8044051 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8044051: Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/610/head:pull/610
$ git checkout pull/610

Update a local copy of the PR:
$ git checkout pull/610
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 610

View PR using the GUI difftool:
$ git pr show -t 610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/610.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9b8b6695108762063f96a275d9567bed72b88126 8044051: Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation Dec 5, 2024
@openjdk
Copy link

openjdk bot commented Dec 5, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2024

Webrevs

@yaqsun
Copy link
Contributor Author

yaqsun commented Dec 5, 2024

/approval 8044051 request test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation for jdk8u

@openjdk
Copy link

openjdk bot commented Dec 5, 2024

@yaqsun
8044051: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 5, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant