Replace conversion to ObjectUtils.isEmpty with !StringUtils.hasLength

build.gradle.kts

@@ -145,6 +145,7 @@ dependencies {
         exclude("com.google.auto.service", "auto-service-annotations")
     }
     implementation("org.mongodb:mongo-java-driver:3.12.+")
+    implementation("org.springframework:spring-core:5.3.+")
     implementation("org.springframework.data:spring-data-mongodb:2.2.+"){
         because("We only require the classes (for refaster style recipes), not the dependencies")
         exclude(group = "org.springframework")

src/main/java/org/openrewrite/java/spring/StringOptimization.java

@@ -0,0 +1,27 @@
+package org.openrewrite.java.spring;
+
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import org.openrewrite.java.template.RecipeDescriptor;
+import org.springframework.util.StringUtils;
+
+@SuppressWarnings("ALL")
+public class StringOptimization {
+
+    @RecipeDescriptor(
+            name = "Use `!StringUtils.hasLength`",
+            description = "Replace usage of deprecated `StringUtils.isEmpty` with `!StringUtils.hasLength` https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/StringUtils.html#isEmpty(java.lang.Object).")
+    static class ReplaceDeprecatedStringUtilsIsEmpty {
+
+
+        @BeforeTemplate
+        boolean before(String s) {
+            return StringUtils.isEmpty(s);
+        }
+
+        @AfterTemplate
+        boolean after(String s) {
+            return !StringUtils.hasLength(s);
+        }
+    }
+}

src/main/resources/META-INF/rewrite/spring-framework-53.yml

@@ -32,7 +32,7 @@ recipeList:
       artifactId: "*"
       newVersion: 5.3.x
       overrideManagedVersion: false
-  - org.openrewrite.java.spring.framework.UseObjectUtilsIsEmpty
+  - org.openrewrite.java.spring.StringOptimizationRecipes.ReplaceDeprecatedStringUtilsIsEmptyRecipe
   - org.openrewrite.java.spring.framework.MigrateHandlerInterceptor
   - org.openrewrite.java.spring.framework.MigrateInstantiationAwareBeanPostProcessorAdapter
   - org.openrewrite.java.spring.framework.JdbcTemplateObjectArrayArgToVarArgs
@@ -51,11 +51,4 @@ recipeList:
       groupId: cglib
       artifactId: cglib
 ---
-type: specs.openrewrite.org/v1beta/recipe
-name: org.openrewrite.java.spring.framework.UseObjectUtilsIsEmpty
-displayName: Use `ObjectUtils#isEmpty(Object)`
-description: '`StringUtils#isEmpty(Object)` was deprecated in 5.3.'
-recipeList:
-  - org.openrewrite.java.ChangeMethodTargetToStatic:
-      methodPattern: org.springframework.util.StringUtils isEmpty(Object)
-      fullyQualifiedTargetTypeName: org.springframework.util.ObjectUtils
+

src/test/java/org/openrewrite/java/spring/ReplaceDeprecatedStringUtilsIsEmptyTest.java

@@ -0,0 +1,45 @@
+package org.openrewrite.java.spring;
+
+import org.junit.jupiter.api.Test;
+import org.openrewrite.DocumentExample;
+import org.openrewrite.InMemoryExecutionContext;
+import org.openrewrite.java.JavaParser;
+import org.openrewrite.test.RecipeSpec;
+import org.openrewrite.test.RewriteTest;
+
+import static org.openrewrite.java.Assertions.java;
+
+class ReplaceDeprecatedStringUtilsIsEmptyTest implements RewriteTest {
+
+    @Override
+    public void defaults(RecipeSpec spec){
+        spec.recipe(new StringOptimizationRecipes()).parser(JavaParser.fromJavaVersion().classpathFromResources(new InMemoryExecutionContext(),"spring-core-5.+"));
+    }
+
+    @DocumentExample
+    @Test
+    @SuppressWarnings("deprecation")
+    void replaceStringUtilsIsEmpty() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import org.springframework.util.StringUtils;
+              class Test {
+                    void test(String s) {
+                      return StringUtils.isEmpty(s);
+                    }
+              }
+              """,
+            """
+              import org.springframework.util.StringUtils;
+              class Test {
+                    void test(String s) {
+                      return !StringUtils.hasLength(s);
+                    }
+              }
+              """
+          )
+        );
+    }
+}