fix(DefaultComesLast)[#289]: duplicate case fix #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
May 19, 2024
There was a problem hiding this comment.
Thanks a lot for taking this on! I have a slight worry about the test case, and with that the logic that we have now. Would you agree we need to assert a different outcome @delanym ?
src/test/java/org/openrewrite/staticanalysis/DefaultComesLastTest.java
Outdated
Show resolved
Hide resolved
punkratz312
reviewed
Oct 12, 2024
| @@ -75,7 +75,7 @@ public J.Switch visitSwitch(J.Switch switch_, P p) { | |||
| aCase.getStatements().isEmpty() && !foundNonEmptyCase) { | |||
| casesGroupedWithDefault.add(aCase); | |||
| } else { | |||
| if (defaultCase != null && defaultCase.getStatements().isEmpty() && !foundNonEmptyCase) { | |||
| if (defaultCase != null && defaultCase.getStatements().isEmpty() && foundNonEmptyCase) { | |||
There was a problem hiding this comment.
Suggested change
| if (defaultCase != null && defaultCase.getStatements().isEmpty() && foundNonEmptyCase) { | |
| if (nonNull(defaultCase) && isEmpty(defaultCase.getStatements()) && foundNonEmptyCase) { |
https://stackoverflow.com/questions/28140193/purpose-of-objects-isnull-objects-nonnull
https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/CollectionUtils.html#isEmpty(java.util.Collection)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fix for DefaultComesLast recipe creates duplicate case #289
What's your motivation?
Bug fix