Empty lines test #369
Draft
Empty lines test #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
timtebeek
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Great to see this kicked off! I've posted a few quick suggestion even if this is still a draft. In general we try to have a single @DocumentExample annotated test, which we've shown in the docs before. That also helps folks spot which test to copy and modify if they want to report an @Issue.
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/staticanalysis/EmptyLinesTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix line missalining to accordingly Java Code Conventions
https://www.oracle.com/technetwork/java/codeconventions-150003.pdf