Onboard update workflow API; add more guardrails and fine-grained state management #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
…readonly Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
changed the title
dbwiddis
approved these changes
Apr 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
…te management (#127) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2a9f3a7)
ohltyler
added a commit
that referenced
this pull request
Apr 5, 2024
…te management (#127) (#128) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2a9f3a7) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finishes out the basic CRUD flows for workflows, by adding support for updates to existing workflows, and further guardrails to prevent performing unsupported actions, such as provisioning with unsaved changes, making changes after provisioning, and only allowing more change after deprovisioning. Note that for update we only pass around the stateless
WorkflowTemplateconfiguration, since this is what the update API expects. It doesn't make sense to includelastUpdatedas part of the template body when running the update API, for example. The utility function to strip down the state-related fields will be useful down the road as the single obj to pass around and have it be exportable as well.Note the main purpose is to implement all of the state management and be able to reflect them in some way on the UI. The final UX regarding how we will display the current state and current constraints is TBD. Also note that workflow versioning and potential changes to how we may support multi-provisioning may also have future impacts.
Demo video:
screen-capture.27.webm
Issues Resolved
Resolves #75
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.