Add query param list in advanced transform modals #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
bug
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
approved these changes
Dec 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Add param list in all modals if applicable Signed-off-by: Tyler Ohlsen <[email protected]> * Prevent duplicate keys for ML inputs/outputs Signed-off-by: Tyler Ohlsen <[email protected]> * Remove optional flag for search processors Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 6f8cbae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Add param list in all modals if applicable * Prevent duplicate keys for ML inputs/outputs * Remove optional flag for search processors --------- (cherry picked from commit 6f8cbae) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Option 1 stated in the issue #528. All advanced transform modals now show the query param list (if applicable) under search-related contexts, such that the query, or the response from the query, can be fully populated with a valid query before executing and fetching the preview source data.
Other minor improvements:
Demo video, showing the params appearing in the 3 different advanced transform modals, and how the options for inputs/outputs dynamically change, based on what is already configured:
screen-capture.6.webm
Issues Resolved
Closes #528
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.