Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding @0ctopus13prime as the maintainer for the k-NN repo #2364

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adding @0ctopus13prime as the maintainer for the k-NN repo #2364

wants to merge 1 commit into from
+2 −1

Conversation

navneet1v
Copy link
Collaborator

Description

Adding @0ctopus13prime as the maintainer for the k-NN repo

Related Issues

NA

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v
Copy link
Collaborator Author

The error on codeowners file is due to @0ctopus13prime doesn't have write access. He will be added in the write access once we have approval on this PR.

@navneet1v
Copy link
Collaborator Author

@opensearch-project/admin can anyone help here to move this adding of maintainer PR to next step.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jan 3, 2025 •
edited
Loading

Please create a similar ticket like this:
opensearch-project/.github#248

And please sync us the vote email chain.
And ask all the +1 maintainers to approve this PR.
Please DO NOT merge this PR until admin give a co-approval

Thanks.

@peterzhuamazon peterzhuamazon marked this pull request as draft January 3, 2025 20:47
@navneet1v
Copy link
Collaborator Author

@peterzhuamazon I have created the issue: opensearch-project/.github#257

@navneet1v
Copy link
Collaborator Author

And please sync us the vote email chain.

added

@navneet1v
Copy link
Collaborator Author

navneet1v commented Jan 3, 2025 •
edited
Loading

And ask all the +1 maintainers to approve this PR.

@martin-gaievski , @ryanbogan , @heemin32 , @vamshin to approve the PR as suggested next steps by @peterzhuamazon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatejas shatejas shatejas approved these changes

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@naveentatikonda naveentatikonda naveentatikonda approved these changes

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@VijayanB VijayanB VijayanB approved these changes

@ryanbogan ryanbogan ryanbogan approved these changes

@heemin32 heemin32 heemin32 approved these changes

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

Assignees
No one assigned
Labels
backport 2.x skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@navneet1v @peterzhuamazon @heemin32 @ryanbogan @VijayanB @jmazanec15 @naveentatikonda @martin-gaievski @shatejas