update rename ~/.benchmark to ~/.osb and add symlink #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Oviedo <[email protected]>
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
gkamat
approved these changes
Jan 2, 2025
gkamat
requested changes
Jan 2, 2025
| new_path = os.path.join(default_home, ".osb") | ||
| if os.path.exists(old_path) and not os.path.exists(new_path): | ||
| os.symlink(old_path, new_path) | ||
| return os.path.join(os.getenv("BENCHMARK_HOME", default_home), ".osb") |
There was a problem hiding this comment.
If the .benchmark directory does not exist, you will need to create it, so both are present in all cases.
Signed-off-by: Michael Oviedo <[email protected]>
|
@gkamat could there be a permissions issue when creating the symlink in the integ tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates OSB's config directory to
~/.osbinstead of~/.benchmark. Also adds a symlink if the old path exists but the new one does not. 'benchmark' is an overloaded term, while using~/.osbreduces ambiguity and is more consistent with the project's name.Issues Resolved
[List any issues this PR will resolve]
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.