-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-47658: [release-4.16][manual]: Fix context deadlines in ExecCommandOnPod() #1263
OCPBUGS-47658: [release-4.16][manual]: Fix context deadlines in ExecCommandOnPod() #1263
Conversation
During testing on x86_64 cluster from an arm64 host, I\'ve observed strange context deadlines when enabling stdin in ExecCommandOnPod() function. Disable stdin as it is not needed during non-interactive tests. Other changes: * Drop unnecessary "/bin/bash -c" in some tests. Further cleanup possible, but it could make code slightly less readable, so avoiding it for now. Signed-off-by: Talor Itzhak <[email protected]> (cherry picked from commit openshift@0e994c7)
We should backport this PR up until 4.14. I see similar symptoms in: openshift-kni/cnf-features-deploy#2135 |
/jira cherry-pick OCPBUGS-43877 |
@yanirq: Jira Issue OCPBUGS-43877 has been cloned as Jira Issue OCPBUGS-47658. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Tal-or: This pull request references Jira Issue OCPBUGS-47658, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
/cherry-pick release-4.15 |
@Tal-or: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold I want to check if this PR fixes the issue on openshift-kni/cnf-features-deploy#2135 |
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold cancel |
Thank you for the backport. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, Tal-or, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label cherry-pick-approved |
/label backport-risk-assessed |
5f37137
into
openshift:release-4.16
@Tal-or: Jira Issue OCPBUGS-47658: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-47658 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Tal-or: #1263 failed to apply on top of branch "release-4.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
Manual and partial backport of #1189