OCPBUGS-36293: aws: bump capa to fix EIP leak on bootstrap when BYOIP #8676

mtulio · 2024-06-27T20:24:27Z

This change bumps CAPA to latest version (main/3f3ce56102048a3c58937c3964feb2d3da826743) with fixes of EIP leak when provisioning Machine (bootstrap) with public IP using Public IPv4 pool, merged on PR kubernetes-sigs/cluster-api-provider-aws#5039.

This is the diff commits from the version used currently on installer: kubernetes-sigs/cluster-api-provider-aws@v2.6.1...main

https://issues.redhat.com/browse/OCPBUGS-36293

Tests: all e2e-aws* jobs running on us-east-1 should receive a lease, when there is available, to acquire an BYO IPv4 pool ID to CAPA provisioning resources consuming public IP from that pool, see the step for more information. The job e2e-aws-ovn-public-ipv4-pool-disabled is enforcing to not use the pool while ensuring the test without BYO IP feature.

openshift-ci · 2024-06-27T20:24:32Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

mtulio · 2024-06-28T18:43:16Z

/test ?

openshift-ci · 2024-06-28T18:43:45Z

@mtulio: The following commands are available to trigger required jobs:

/test agent-integration-tests
/test altinfra-images
/test aro-unit
/test e2e-agent-compact-ipv4
/test e2e-aws-ovn
/test e2e-aws-ovn-edge-zones-manifest-validation
/test e2e-aws-ovn-upi
/test e2e-azure-ovn
/test e2e-azure-ovn-upi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test gofmt
/test golint
/test govet
/test images
/test okd-images
/test okd-unit
/test okd-verify-codegen
/test openstack-manifests
/test shellcheck
/test terraform-images
/test terraform-verify-vendor
/test tf-lint
/test unit
/test verify-codegen
/test verify-vendor
/test yaml-lint

The following commands are available to trigger optional jobs:

/test altinfra-e2e-aws-custom-security-groups
/test altinfra-e2e-aws-ovn
/test altinfra-e2e-aws-ovn-fips
/test altinfra-e2e-aws-ovn-imdsv2
/test altinfra-e2e-aws-ovn-localzones
/test altinfra-e2e-aws-ovn-proxy
/test altinfra-e2e-aws-ovn-public-ipv4-pool
/test altinfra-e2e-aws-ovn-shared-vpc
/test altinfra-e2e-aws-ovn-shared-vpc-local-zones
/test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
/test altinfra-e2e-aws-ovn-single-node
/test altinfra-e2e-aws-ovn-wavelengthzones
/test altinfra-e2e-azure-capi-ovn
/test altinfra-e2e-gcp-capi-ovn
/test altinfra-e2e-gcp-ovn-byo-network-capi
/test altinfra-e2e-gcp-ovn-secureboot-capi
/test altinfra-e2e-gcp-ovn-xpn-capi
/test altinfra-e2e-ibmcloud-capi-ovn
/test altinfra-e2e-nutanix-capi-ovn
/test altinfra-e2e-openstack-capi-ccpmso
/test altinfra-e2e-openstack-capi-ccpmso-zone
/test altinfra-e2e-openstack-capi-dualstack
/test altinfra-e2e-openstack-capi-dualstack-upi
/test altinfra-e2e-openstack-capi-dualstack-v6primary
/test altinfra-e2e-openstack-capi-externallb
/test altinfra-e2e-openstack-capi-nfv-intel
/test altinfra-e2e-openstack-capi-ovn
/test altinfra-e2e-openstack-capi-proxy
/test altinfra-e2e-powervs-capi-ovn
/test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
/test altinfra-e2e-vsphere-capi-ovn
/test altinfra-e2e-vsphere-capi-static-ovn
/test altinfra-e2e-vsphere-capi-zones
/test azure-ovn-marketplace-images
/test e2e-agent-compact-ipv4-appliance-diskimage
/test e2e-agent-compact-ipv4-none-platform
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv4-pxe
/test e2e-agent-sno-ipv6
/test e2e-aws-overlay-mtu-ovn-1200
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-imdsv2
/test e2e-aws-ovn-proxy
/test e2e-aws-ovn-public-subnets
/test e2e-aws-ovn-shared-vpc-custom-security-groups
/test e2e-aws-ovn-shared-vpc-edge-zones
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-upi-proxy
/test e2e-azure-ovn-resourcegroup
/test e2e-azure-ovn-shared-vpc
/test e2e-azurestack
/test e2e-azurestack-upi
/test e2e-crc
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-gcp-ovn-byo-vpc
/test e2e-gcp-ovn-xpn
/test e2e-gcp-secureboot
/test e2e-gcp-upgrade
/test e2e-gcp-upi-xpn
/test e2e-ibmcloud-ovn
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-swapped-hosts
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-single-node-live-iso
/test e2e-nutanix-ovn
/test e2e-openstack-ccpmso
/test e2e-openstack-ccpmso-zone
/test e2e-openstack-dualstack
/test e2e-openstack-dualstack-upi
/test e2e-openstack-externallb
/test e2e-openstack-nfv-intel
/test e2e-openstack-proxy
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-upi-zones
/test e2e-vsphere-ovn-zones
/test e2e-vsphere-ovn-zones-techpreview
/test e2e-vsphere-static-ovn
/test okd-e2e-agent-compact-ipv4
/test okd-e2e-agent-ha-dualstack
/test okd-e2e-agent-sno-ipv6
/test okd-e2e-aws-ovn
/test okd-e2e-aws-ovn-upgrade
/test okd-e2e-gcp
/test okd-e2e-gcp-ovn-upgrade
/test okd-e2e-vsphere
/test okd-scos-e2e-aws-ovn
/test okd-scos-images
/test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn
pull-ci-openshift-installer-master-altinfra-images
pull-ci-openshift-installer-master-aro-unit
pull-ci-openshift-installer-master-e2e-aws-ovn
pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones
pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones-manifest-validation
pull-ci-openshift-installer-master-e2e-aws-ovn-fips
pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-custom-security-groups
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-edge-zones
pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
pull-ci-openshift-installer-master-e2e-external-aws-ccm
pull-ci-openshift-installer-master-gofmt
pull-ci-openshift-installer-master-golint
pull-ci-openshift-installer-master-govet
pull-ci-openshift-installer-master-images
pull-ci-openshift-installer-master-okd-unit
pull-ci-openshift-installer-master-okd-verify-codegen
pull-ci-openshift-installer-master-shellcheck
pull-ci-openshift-installer-master-tf-fmt
pull-ci-openshift-installer-master-tf-lint
pull-ci-openshift-installer-master-unit
pull-ci-openshift-installer-master-verify-codegen
pull-ci-openshift-installer-master-verify-vendor
pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mtulio · 2024-06-28T18:44:53Z

/test altinfra-e2e-aws-ovn-public-ipv4-pool

mtulio · 2024-08-27T22:19:33Z

feedback addressed in upstream PR (kubernetes-sigs/cluster-api-provider-aws#5039) to improve the reconciliation loop by not show error messages while the instance isn't running (expected):

/test altinfra-e2e-aws-ovn-public-ipv4-pool

mtulio · 2024-08-28T14:27:09Z

feedback addressed in upstream PR (kubernetes-sigs/cluster-api-provider-aws#5039) to improve the reconciliation loop by not show error messages while the instance isn't running (expected):

/test altinfra-e2e-aws-ovn-public-ipv4-pool

Job is passing, now CAPA is printing only debug messages (instead of errors in expected situations in the reconciliator loop):

wget -O /tmp/install.log https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_installer/8676/pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-public-ipv4-pool/1828558006120353792/artifacts/e2e-aws-ovn-public-ipv4-pool/ipi-install-install/artifacts/.openshift_install-1724801306.log

$ grep -c 'publicIpv4Pool reconciling instance' /tmp/install.log
13

$ grep -c 'awsmachine_controller.go:550\] \\"find the instance is pending, requeue\\"' /tmp/install.log
2

$ grep -c 'Reconciling machine with custom Public IPv4 Pool' /tmp/install.log
13

$ grep -c 'unable to reconcile Elastic IP Pool to '  /tmp/install.log
2

$ grep -c 'machine is already associated with an Elastic IP with custom Public IPv4 pool' /tmp/install.log
10

mtulio · 2024-08-28T14:27:26Z

/test altinfra-e2e-aws-ovn-public-ipv4-pool

mtulio · 2024-08-29T19:10:30Z

I am seeing upstream e2e issues, ensuring downstream are ok:

/test altinfra-e2e-aws-ovn-public-ipv4-pool

/test altinfra-e2e-aws-ovn

mtulio · 2024-08-29T19:10:41Z

/test e2e-aws-ovn

mtulio · 2024-08-29T19:14:12Z

/test all

mtulio · 2024-08-30T20:43:56Z

/test ?

openshift-ci · 2024-08-30T20:44:00Z

@mtulio: The following commands are available to trigger required jobs:

/test altinfra-images
/test aro-unit
/test e2e-agent-compact-ipv4
/test e2e-aws-ovn
/test e2e-aws-ovn-edge-zones-manifest-validation
/test e2e-aws-ovn-upi
/test e2e-azure-ovn
/test e2e-azure-ovn-upi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test gofmt
/test golint
/test govet
/test images
/test integration-tests
/test okd-images
/test okd-unit
/test okd-verify-codegen
/test openstack-manifests
/test shellcheck
/test terraform-images
/test terraform-verify-vendor
/test tf-lint
/test unit
/test verify-codegen
/test verify-vendor
/test yaml-lint

The following commands are available to trigger optional jobs:

/test altinfra-e2e-aws-custom-security-groups
/test altinfra-e2e-aws-ovn
/test altinfra-e2e-aws-ovn-fips
/test altinfra-e2e-aws-ovn-imdsv2
/test altinfra-e2e-aws-ovn-localzones
/test altinfra-e2e-aws-ovn-proxy
/test altinfra-e2e-aws-ovn-shared-vpc
/test altinfra-e2e-aws-ovn-shared-vpc-local-zones
/test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
/test altinfra-e2e-aws-ovn-single-node
/test altinfra-e2e-aws-ovn-wavelengthzones
/test altinfra-e2e-azure-capi-ovn
/test altinfra-e2e-azure-ovn-shared-vpc
/test altinfra-e2e-gcp-capi-ovn
/test altinfra-e2e-gcp-ovn-byo-network-capi
/test altinfra-e2e-gcp-ovn-secureboot-capi
/test altinfra-e2e-gcp-ovn-xpn-capi
/test altinfra-e2e-ibmcloud-capi-ovn
/test altinfra-e2e-nutanix-capi-ovn
/test altinfra-e2e-openstack-capi-ccpmso
/test altinfra-e2e-openstack-capi-ccpmso-zone
/test altinfra-e2e-openstack-capi-dualstack
/test altinfra-e2e-openstack-capi-dualstack-upi
/test altinfra-e2e-openstack-capi-dualstack-v6primary
/test altinfra-e2e-openstack-capi-externallb
/test altinfra-e2e-openstack-capi-nfv-intel
/test altinfra-e2e-openstack-capi-ovn
/test altinfra-e2e-openstack-capi-proxy
/test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
/test altinfra-e2e-vsphere-capi-ovn
/test altinfra-e2e-vsphere-capi-static-ovn
/test altinfra-e2e-vsphere-capi-zones
/test azure-ovn-marketplace-images
/test e2e-agent-compact-ipv4-add-nodes
/test e2e-agent-compact-ipv4-appliance-diskimage
/test e2e-agent-compact-ipv4-none-platform
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv4-pxe
/test e2e-agent-sno-ipv6
/test e2e-aws-overlay-mtu-ovn-1200
/test e2e-aws-ovn-custom-iam-profile
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-heterogeneous
/test e2e-aws-ovn-imdsv2
/test e2e-aws-ovn-proxy
/test e2e-aws-ovn-public-ipv4-pool
/test e2e-aws-ovn-public-ipv4-pool-disabled
/test e2e-aws-ovn-public-subnets
/test e2e-aws-ovn-shared-vpc-custom-security-groups
/test e2e-aws-ovn-shared-vpc-edge-zones
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-techpreview
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-upi-proxy
/test e2e-azure-ovn-resourcegroup
/test e2e-azure-ovn-shared-vpc
/test e2e-azure-ovn-techpreview
/test e2e-azurestack
/test e2e-azurestack-upi
/test e2e-crc
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-gcp-ovn-byo-vpc
/test e2e-gcp-ovn-heterogeneous
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-xpn
/test e2e-gcp-secureboot
/test e2e-gcp-upgrade
/test e2e-gcp-upi-xpn
/test e2e-ibmcloud-ovn
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-swapped-hosts
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-single-node-live-iso
/test e2e-nutanix-ovn
/test e2e-openstack-ccpmso
/test e2e-openstack-ccpmso-zone
/test e2e-openstack-dualstack
/test e2e-openstack-dualstack-upi
/test e2e-openstack-externallb
/test e2e-openstack-nfv-intel
/test e2e-openstack-proxy
/test e2e-powervs-capi-ovn
/test e2e-vsphere-multi-vcenter-ovn
/test e2e-vsphere-ovn-multi-network
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-upi-zones
/test e2e-vsphere-ovn-zones
/test e2e-vsphere-ovn-zones-techpreview
/test e2e-vsphere-static-ovn
/test okd-e2e-agent-compact-ipv4
/test okd-e2e-agent-ha-dualstack
/test okd-e2e-agent-sno-ipv6
/test okd-e2e-aws-ovn
/test okd-e2e-aws-ovn-upgrade
/test okd-e2e-gcp
/test okd-e2e-gcp-ovn-upgrade
/test okd-e2e-vsphere
/test okd-scos-images
/test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn
pull-ci-openshift-installer-master-altinfra-images
pull-ci-openshift-installer-master-aro-unit
pull-ci-openshift-installer-master-e2e-aws-ovn
pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones
pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones-manifest-validation
pull-ci-openshift-installer-master-e2e-aws-ovn-fips
pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous
pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-custom-security-groups
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-edge-zones
pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
pull-ci-openshift-installer-master-e2e-external-aws-ccm
pull-ci-openshift-installer-master-gofmt
pull-ci-openshift-installer-master-golint
pull-ci-openshift-installer-master-govet
pull-ci-openshift-installer-master-images
pull-ci-openshift-installer-master-okd-unit
pull-ci-openshift-installer-master-okd-verify-codegen
pull-ci-openshift-installer-master-shellcheck
pull-ci-openshift-installer-master-tf-fmt
pull-ci-openshift-installer-master-tf-lint
pull-ci-openshift-installer-master-unit
pull-ci-openshift-installer-master-verify-codegen
pull-ci-openshift-installer-master-verify-vendor
pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mtulio · 2024-08-30T20:44:25Z

openshift/release#56114 merged. Checking if I can run a job that the pool is disabled in CAPI:

/test e2e-aws-ovn-public-ipv4-pool-disabled

mtulio · 2024-09-05T19:05:46Z

/test e2e-aws-ovn-public-ipv4-pool-disabled
/test e2e-aws-ovn-public-ipv4-pool

mtulio · 2024-09-05T19:08:10Z

/test e2e-aws-ovn-public-ipv4-pool-disabled
/test e2e-aws-ovn-public-ipv4-pool

vr4manta · 2024-09-10T17:57:07Z

/lgtm

mtulio · 2024-09-10T17:57:24Z

/assign @patrickdillon @r4f4

mtulio · 2024-09-10T18:15:02Z

/jira refresh

openshift-ci-robot · 2024-09-10T18:15:09Z

@mtulio: This pull request references Jira Issue OCPBUGS-36293, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mtulio · 2024-09-10T18:24:37Z

/test e2e-aws-ovn-public-ipv4-pool

openshift-ci-robot · 2024-09-10T18:27:10Z

@mtulio: This pull request references Jira Issue OCPBUGS-36293, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

This change bumps CAPA to latest version (main/3f3ce56102048a3c58937c3964feb2d3da826743) with fixes of EIP leak when provisioning Machine (bootstrap) with public IP using Public IPv4 pool, merged on PR kubernetes-sigs/cluster-api-provider-aws#5039.

This is the diff commits from the version used currently on installer: kubernetes-sigs/cluster-api-provider-aws@v2.6.1...main

https://issues.redhat.com/browse/OCPBUGS-36293

Tests: all e2e-aws* jobs running on us-east-1 should receive a lease, when there is available, to acquire an BYO IPv4 pool ID to CAPA provisioning resources consuming public IP from that pool, see the step for more information. The job e2e-aws-ovn-public-ipv4-pool-disabled is enforcing to not use the pool while ensuring the test without BYO IP feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon · 2024-09-10T18:44:51Z

Does this need a bump of https://github.com/openshift/installer/blob/master/data/data/cluster-api/aws-infrastructure-components.yaml?

patrickdillon · 2024-09-10T19:02:36Z

/approve

but lets

/hold

for the ipv4 pool test as it is non blocking. feel free to drop the hold

openshift-ci · 2024-09-10T19:03:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtulio · 2024-09-10T19:06:53Z

Does this need a bump of https://github.com/openshift/installer/blob/master/data/data/cluster-api/aws-infrastructure-components.yaml?

As chatted on Slack, probably we don't need to update it.

Looks like the updates on aws-infrastructure-components.yaml
are mostly changes adding new capabilities like second CIDR block for IPv6 and advanced configuration for extra volumes, no removals, not impacting this change.

openshift-ci · 2024-09-10T20:44:23Z

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-heterogeneous	`5ce8d66`	link	false	`/test e2e-aws-ovn-heterogeneous`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mtulio · 2024-09-10T21:41:42Z

/approve

but lets

/hold

for the ipv4 pool test as it is non blocking. feel free to drop the hold

Thanks!
From the CI jobs, I can see the job forcing to skip BYO IP Pool config (default on CI) [1], and the job enforcing[2] to use the pool, ignoring the quota assignment. Both are working as expected. cc @jupierce @patrickdillon

/hold cancel

The following tests are passing:

1/ e2e-aws-ovn-public-ipv4-pool-disabled: Bootstrap got IP from Amazon Pool \"publicIp\":\"18.188.159.227\",\...:{\"MachineName\":\"openshift-cluster-api-guests/ci-op-cfkbr9vz-4ba8c-hkwr2-bootstrap\"
2/ e2e-aws-ovn-public-ipv4-pool Bootstrap got IP from CI IPv4 Pool

356 eip.go:51] \"Machine is already associated with an Elastic IP with custom Public IPv4 pool\" 
controller=\"awsmachine\" .... controllerKind=\"AWSMachine\" ... 
machine=\"openshift-cluster-api-guests/ci-op-p7tyw9c7-0d850-dzfd9-bootstrap\" 
cluster=\"openshift-cluster-api-guests/ci-op-p7tyw9c7-0d850-dzfd9\" 
eip=\"eipalloc-026314129f08c2a06\" eip-address=\"157.254.217.103\"

openshift-ci-robot · 2024-09-11T00:53:51Z

@mtulio: Jira Issue OCPBUGS-36293: All pull requests linked via external trackers have merged:

openshift/installer#8676

Jira Issue OCPBUGS-36293 has been moved to the MODIFIED state.

In response to this:

This change bumps CAPA to latest version (main/3f3ce56102048a3c58937c3964feb2d3da826743) with fixes of EIP leak when provisioning Machine (bootstrap) with public IP using Public IPv4 pool, merged on PR kubernetes-sigs/cluster-api-provider-aws#5039.

This is the diff commits from the version used currently on installer: kubernetes-sigs/cluster-api-provider-aws@v2.6.1...main

https://issues.redhat.com/browse/OCPBUGS-36293

Tests: all e2e-aws* jobs running on us-east-1 should receive a lease, when there is available, to acquire an BYO IPv4 pool ID to CAPA provisioning resources consuming public IP from that pool, see the step for more information. The job e2e-aws-ovn-public-ipv4-pool-disabled is enforcing to not use the pool while ensuring the test without BYO IP feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mtulio · 2024-09-11T03:49:35Z

/cherrypick release-4.17

mtulio · 2024-09-11T03:49:41Z

/cherrypick release-4.16

openshift-cherrypick-robot · 2024-09-11T03:51:33Z

@mtulio: new pull request created: #8991

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2024-09-11T03:51:42Z

@mtulio: #8676 failed to apply on top of branch "release-4.16":

Applying: OCPBUGS-36293 bump/go.mod fixes of BYO IP leak on CAPA PR 5039
Using index info to reconstruct a base tree...
M	cluster-api/providers/aws/go.mod
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging cluster-api/providers/aws/go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-36293 bump/go.mod fixes of BYO IP leak on CAPA PR 5039
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch from 46c24e3 to 9daa5b3 Compare June 28, 2024 18:42

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch 2 times, most recently from d5720a5 to ee43a06 Compare August 27, 2024 20:49

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2024

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch 2 times, most recently from c5f2e33 to 2004ae2 Compare August 27, 2024 22:17

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch from 2004ae2 to 406dbf5 Compare August 28, 2024 14:27

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch from 406dbf5 to c5f6f91 Compare August 29, 2024 19:10

This was referenced Aug 29, 2024

🐛 ec2/byoip: fix EIP leak when creating machine kubernetes-sigs/cluster-api-provider-aws#5039

Merged

installer/presubmit: adding a job to force disalbe BYO IP openshift/release#56114

Merged

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch from c5f6f91 to 80aefa3 Compare September 5, 2024 19:04

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2024

mtulio force-pushed the OCPBUGS-36293-fix-byoip-eip branch from 80aefa3 to e15160f Compare September 5, 2024 19:08

openshift-ci bot assigned vr4manta Sep 10, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024

openshift-ci bot assigned patrickdillon and r4f4 Sep 10, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 10, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024

openshift-merge-bot bot merged commit 7c39b9a into openshift:master Sep 11, 2024
30 of 31 checks passed

mtulio deleted the OCPBUGS-36293-fix-byoip-eip branch September 11, 2024 03:49

openshift-cherrypick-robot mentioned this pull request Sep 11, 2024

[release-4.17] OCPBUGS-41702: aws: bump capa to fix EIP leak on bootstrap when BYOIP #8991

Merged

r4f4 mentioned this pull request Sep 18, 2024

OCPBUGS-33311: aws: fix NLB creation in secret regions #8636

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-36293: aws: bump capa to fix EIP leak on bootstrap when BYOIP #8676

OCPBUGS-36293: aws: bump capa to fix EIP leak on bootstrap when BYOIP #8676

mtulio commented Jun 27, 2024 •

edited

Loading

openshift-ci bot commented Jun 27, 2024

mtulio commented Jun 28, 2024

openshift-ci bot commented Jun 28, 2024

mtulio commented Jun 28, 2024

mtulio commented Aug 27, 2024 •

edited

Loading

mtulio commented Aug 28, 2024

mtulio commented Aug 28, 2024

mtulio commented Aug 29, 2024

mtulio commented Aug 29, 2024

mtulio commented Aug 29, 2024

mtulio commented Aug 30, 2024

openshift-ci bot commented Aug 30, 2024

mtulio commented Aug 30, 2024

mtulio commented Sep 5, 2024

mtulio commented Sep 5, 2024

vr4manta commented Sep 10, 2024

mtulio commented Sep 10, 2024

mtulio commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

mtulio commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

patrickdillon commented Sep 10, 2024

patrickdillon commented Sep 10, 2024

openshift-ci bot commented Sep 10, 2024

mtulio commented Sep 10, 2024

openshift-ci bot commented Sep 10, 2024

mtulio commented Sep 10, 2024 •

edited

Loading

openshift-ci-robot commented Sep 11, 2024

mtulio commented Sep 11, 2024

mtulio commented Sep 11, 2024

openshift-cherrypick-robot commented Sep 11, 2024

openshift-cherrypick-robot commented Sep 11, 2024

OCPBUGS-36293: aws: bump capa to fix EIP leak on bootstrap when BYOIP #8676

OCPBUGS-36293: aws: bump capa to fix EIP leak on bootstrap when BYOIP #8676

Conversation

mtulio commented Jun 27, 2024 • edited Loading

openshift-ci bot commented Jun 27, 2024

mtulio commented Jun 28, 2024

openshift-ci bot commented Jun 28, 2024

mtulio commented Jun 28, 2024

mtulio commented Aug 27, 2024 • edited Loading

mtulio commented Aug 28, 2024

mtulio commented Aug 28, 2024

mtulio commented Aug 29, 2024

mtulio commented Aug 29, 2024

mtulio commented Aug 29, 2024

mtulio commented Aug 30, 2024

openshift-ci bot commented Aug 30, 2024

mtulio commented Aug 30, 2024

mtulio commented Sep 5, 2024

mtulio commented Sep 5, 2024

vr4manta commented Sep 10, 2024

mtulio commented Sep 10, 2024

mtulio commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

mtulio commented Sep 10, 2024

openshift-ci-robot commented Sep 10, 2024

patrickdillon commented Sep 10, 2024

patrickdillon commented Sep 10, 2024

openshift-ci bot commented Sep 10, 2024

mtulio commented Sep 10, 2024

openshift-ci bot commented Sep 10, 2024

mtulio commented Sep 10, 2024 • edited Loading

openshift-ci-robot commented Sep 11, 2024

mtulio commented Sep 11, 2024

mtulio commented Sep 11, 2024

openshift-cherrypick-robot commented Sep 11, 2024

openshift-cherrypick-robot commented Sep 11, 2024

mtulio commented Jun 27, 2024 •

edited

Loading

mtulio commented Aug 27, 2024 •

edited

Loading

mtulio commented Sep 10, 2024 •

edited

Loading