update-bcd: fix getSupportMatrix overrides param type #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonio12389
approved these changes
Oct 18, 2023
queengooborg
added a commit
that referenced
this pull request
Nov 5, 2023
* update-bcd: fix getSupportMatrix overrides param type * fixup! update-bcd: fix getSupportMatrix overrides param type --------- Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Overridestype used by update-bcd.Further Info
The PR putting update script into BCD fixed the
Overridestype used by update-bcd'sgetSupportMatrix. This change applies small fixes so typescript can check it.Related Issues
mdn/browser-compat-data#19868
mdn/browser-compat-data#19971