Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three new OPL problems and one bug fix #1216

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChenfeiP
Copy link

Feel free to review the revised version of S06.03.VolumesByShells.PTP08.pg

@ChenfeiP
Copy link
Author

Please consider these three problems for addition to the OPL. All three problems are scaffolded and require students to apply limit laws, derivative rules or trig identities one step at a time and identify the correct explanation for their step. This ensures students learn standard names for derivative rules/limit laws and correct terminology, as well as ensures they are able to break things into single steps. At present, there do not seem to be any such scaffolded problems in the OPL.

@ChenfeiP ChenfeiP changed the title Fixed bug #4856 Three new OPT problems and one bug fix Dec 13, 2024
@ChenfeiP ChenfeiP changed the title Three new OPT problems and one bug fix Three new OPL problems and one bug fix Dec 13, 2024
@drdrew42
Copy link
Member

Thanks for these contributions!

There are a few things that need to be resolved here before we can merge.

First, you're adding a new university folder to Contrib, welcome! Please include a README.md in the new 'UMN-Morris' folder containing the github usernames (or name + email) of any individuals from your institution who should be allowed to push new problems into your university folder. Feel free to take a look at other university folders in Contrib for examples.

Next, the three new problems that you've added look good -- except for a few warnings generated by the limits problem. In part three, you have multiple answer blanks that specify x as the correct answer. This should, at the very least, be a string "x" (rather than bareword x), and preferably an explicit MathObject Formula("x").

Finally, there is a merge conflict with your updates to the Rochester washer/shell integration problem. It seems that this problem has already been updated to use PGML.

Changes Requested

  • add Contrib/UMN-Morris/README.md with the names of approved contributors
  • update the limit problem to resolve the bareword 'x' warnings
  • remove the changes to OpenProblemLibrary/Rochester/setIntegrals20Volume/S06.03.VolumesByShells.PTP08.pg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants