-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: allow to define additional configs #728
base: main
Are you sure you want to change the base?
build: allow to define additional configs #728
Conversation
Please fix the failing test. |
3ef4de3
to
60b45b9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 80.94% 86.70% +5.75%
==========================================
Files 15 15
Lines 976 985 +9
==========================================
+ Hits 790 854 +64
+ Misses 186 131 -55 ☔ View full report in Codecov by Sentry. |
60b45b9
to
88f632b
Compare
What is the status of this PR? |
I'm not a huge fan to allow arbitrary changes but since we moved into containers, it might be fine. Is anyone interested in using this? |
88f632b
to
b81385f
Compare
Hi, rebased on current Git HEAD, let me know if there is any interest on this, and/or if there are things that should be improved. I would still be interested. |
b81385f
to
e8cede9
Compare
Should we add a configuration which sets specific CONFIG options which are allowed? I'm a bit unsure this doesn't cause any issues down the road. For example you could simply bypass the root filesystem size limitation of rootfs_size_mb and set it to 100GB, filling up the servers storage... |
This introduces the possibility of passing additional configs to the request.
Only the few not related to kernel/packages, as they are not recompiled by the imagebuilder, would make sense.
For example, to request a specific name/number for a firmware image:
Or to request a format other than the default format for the output firmware image, for example: