Merge pull request #50 from jcchavezs/adds_usability_tweaks

Adds some usability tweaks.
openzipkin · Jan 18, 2018 · 18c1826 · 18c1826
2 parents a5918d7 + 4f29bcd
commit 18c1826
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 6 deletions.
diff --git a/src/Zipkin/Reporters/Http.php b/src/Zipkin/Reporters/Http.php
@@ -55,7 +55,9 @@ public function report(array $spans)
             $client = $this->clientFactory->build($this->options);
             $client($payload);
         } catch (Exception $e) {
-            $this->logger->info($e->getMessage());
+            $this->logger->error(
+                sprintf('Failed to report spans: %s', $e->getMessage())
+            );
         }
     }
 }
diff --git a/src/Zipkin/TracingBuilder.php b/src/Zipkin/TracingBuilder.php
@@ -123,15 +123,23 @@ public function havingTraceId128bits($usesTraceId128bits)
         return $this;
     }
 
+    /**
+     * @param CurrentTraceContext $currentTraceContext
+     * @return $this
+     */
     public function havingCurrentTraceContext(CurrentTraceContext $currentTraceContext)
     {
         $this->currentTraceContext = $currentTraceContext;
         return $this;
     }
 
-    public function beingNoop()
+    /**
+     * @param bool $isNoop
+     * @return $this
+     */
+    public function beingNoop($isNoop = true)
     {
-        $this->isNoop = true;
+        $this->isNoop = $isNoop;
         return $this;
     }
 

diff --git a/tests/Unit/TracingBuilderTest.php b/tests/Unit/TracingBuilderTest.php
@@ -21,7 +21,10 @@ public function testCreatingTracingWithDefaultValuesSuccess()
         $this->assertEquals(false, $tracing->isNoop());
     }
 
-    public function testCreatingTracingIncludesExpectedValues()
+    /**
+     * @dataProvider boolProvider
+     */
+    public function testCreatingTracingIncludesExpectedValues($isNoop)
     {
         $endpoint = Endpoint::createAsEmpty();
         $reporter = new Noop();
@@ -36,11 +39,19 @@ public function testCreatingTracingIncludesExpectedValues()
             ->havingSampler($sampler)
             ->havingTraceId128bits($usesTraceId128bits)
             ->havingCurrentTraceContext($currentTraceContext)
-            ->beingNoop()
+            ->beingNoop($isNoop)
             ->build();
 
         $this->assertInstanceOf(Tracing::class, $tracing);
-        $this->assertEquals(true, $tracing->isNoop());
+        $this->assertEquals($isNoop, $tracing->isNoop());
+    }
+
+    public function boolProvider()
+    {
+        return [
+            [true],
+            [false]
+        ];
     }
 
     private function randomBool()