Merge pull request #47 from jcchavezs/adds_curl_integration

Adds cURL integration test.

composer.json

@@ -18,7 +18,8 @@
     "require-dev": {
         "phpunit/phpunit": "~5.7.19",
         "squizlabs/php_codesniffer": "3.*",
-        "guzzlehttp/psr7": "^1.4"
+        "guzzlehttp/psr7": "^1.4",
+        "jcchavezs/httptest": "0.1-beta2"
     },
     "autoload": {
         "psr-4": {

src/Zipkin/Reporters/Http/CurlFactory.php

@@ -7,6 +7,10 @@
 
 final class CurlFactory implements ClientFactory
 {
+    /**
+     * @return CurlFactory
+     * @throws \BadFunctionCallException if the curl extension is not installed.
+     */
     public static function create()
     {
         if (!function_exists('curl_init')) {

tests/Integration/Reporters/Http/CurlFactoryTest.php

@@ -0,0 +1,95 @@
+<?php
+
+namespace ZipkinTests\Integration\Reporters\Http;
+
+use Exception;
+use HttpTest\HttpTestServer;
+use PHPUnit_Framework_TestCase;
+use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
+use RuntimeException;
+use Zipkin\Reporters\Http\CurlFactory;
+
+final class CurlFactoryTest extends PHPUnit_Framework_TestCase
+{
+    public function testHttpReportingSuccess()
+    {
+        $t = $this;
+
+        $server = HttpTestServer::create(
+            function (RequestInterface $request, ResponseInterface &$response) use ($t) {
+                $t->assertEquals('POST', $request->getMethod());
+                $t->assertEquals('application/json', $request->getHeader('Content-Type')[0]);
+                $response = $response->withStatus(202);
+            }
+        );
+
+        $pid = pcntl_fork();
+
+        if ($pid === -1) {
+            $this->fail('Error forking thread.');
+        } elseif ($pid) {
+            $server->start();
+        } else {
+            $server->waitForReady();
+
+            try {
+                $curlClient = CurlFactory::create()->build([
+                    'endpoint_url' => $server->getUrl(),
+                ]);
+
+                $curlClient(json_encode([]));
+            } catch (Exception $e) {
+                $this->fail($e->getMessage());
+            } finally {
+                $server->stop();
+            }
+        }
+    }
+
+    public function testHttpReportingFailsDueToInvalidStatusCode()
+    {
+        $server = HttpTestServer::create(
+            function (RequestInterface $request, ResponseInterface &$response) {
+                $response = $response->withStatus(404);
+            }
+        );
+
+        $pid = pcntl_fork();
+
+        if ($pid === -1) {
+            $this->fail('Error forking thread.');
+        } elseif ($pid) {
+            $server->start();
+        } else {
+            $server->waitForReady();
+
+            try {
+                $this->expectException(RuntimeException::class);
+                $this->expectExceptionMessage('Reporting of spans failed');
+
+                $curlClient = CurlFactory::create()->build([
+                    'endpoint_url' => $server->getUrl(),
+                ]);
+
+                $curlClient('');
+
+                $this->fail('Runtime exception expected');
+            } finally {
+                $server->stop();
+            }
+        }
+    }
+
+    public function testHttpReportingFailsDueToUnreachableUrl()
+    {
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Reporting of spans failed');
+
+        $curlClient = CurlFactory::create()->build([
+            'endpoint_url' => 'invalid_url',
+        ]);
+
+        $curlClient('');
+    }
+}