Merge pull request #72 from Achal1607/javavscode-71

[JAVAVSCODE-71] Updated download.jdk command configuration to open JDK downloader window even if no folder is open in workspace
oracle · Nov 28, 2023 · 63339ea · 63339ea
2 parents 285afe4 + f8ab2e3
commit 63339ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/vscode/package.json b/vscode/package.json
@@ -483,6 +483,9 @@
 				{
 					"command": "jdk.workspace.newproject"
 				},
+				{
+					"command": "jdk.download.jdk"
+				},
 				{
 					"command": "jdk.workspace.compile",
 					"when": "nbJdkReady"

diff --git a/vscode/src/extension.ts b/vscode/src/extension.ts
@@ -444,6 +444,7 @@ export function activate(context: ExtensionContext): VSNetBeansAPI {
             throw `Client ${c} doesn't support new project`;
         }
     }));
+    context.subscriptions.push(vscode.commands.registerCommand(COMMAND_PREFIX + ".download.jdk", async () => { openJDKSelectionView(log); }));
     context.subscriptions.push(commands.registerCommand(COMMAND_PREFIX + '.workspace.compile', () =>
         wrapCommandWithProgress(COMMAND_PREFIX + '.build.workspace', 'Compiling workspace...', log, true)
     ));
@@ -1109,7 +1110,6 @@ function doActivateWithJDK(specifiedJDK: string | null, context: ExtensionContex
             }
         }));
         ctx.subscriptions.push(vscode.commands.registerCommand(COMMAND_PREFIX + ".select.editor.projects", () => revealActiveEditor()));
-        ctx.subscriptions.push(vscode.commands.registerCommand(COMMAND_PREFIX + ".download.jdk", () => openJDKSelectionView(log)));
 
         // attempt to reveal NOW:
         if (netbeansConfig.get("revealActiveInProjects")) {