Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netbeans tests failures on MacOS #313

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

sid-srini
Copy link
Member

@sid-srini sid-srini commented Oct 30, 2024

Adding the patch for the netbeans PR apache/netbeans#7926, to fix the unit test failures in the java.hints module due to old Apple JDK 6 special treatment for the expected output.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 30, 2024
@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Oct 30, 2024
@sid-srini sid-srini force-pushed the fix_netbeans_macos_tests_failures branch 2 times, most recently from ae7731a to aeeb573 Compare October 30, 2024 11:34
Achal1607
Achal1607 previously approved these changes Nov 4, 2024
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Adding the patch for the netbeans PR #7926 to fix the unit test failures
in the java.hints module due to old Apple JDK 6 special treatment for the
expected output.

Signed-off-by: Siddharth Srinivasan <[email protected]>
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sid-srini sid-srini merged commit 1814a3e into oracle:main Nov 4, 2024
3 checks passed
@sid-srini sid-srini deleted the fix_netbeans_macos_tests_failures branch November 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants