Fixes and edits to telemetry code to support JdkFeatureEvent #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Amended LspServerTelemetryManager to expose isPreviewEnabled() method and associated enums and methods to populate JdkFeatureEvent. 2. Amended NbCodeClientCapabilites.wantsTelemetryEnabled() to avoid an NPE in case of null Boolean -> boolean conversion. 3. Fixed handlers.ts to receive jdkFeature event from LSP and send it to the telemetry reporter. 4. Fixed jdkFeatures.ts to properly coalesce multiple events. Signed-off-by: Siddharth Srinivasan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the existing telemetry framework to support the handling and reporting of jdkFeature events.
Also, amended utilities to aid in populating fields of the jdkFeature event.
Note: this is the preliminary commit in the PR #350 which provides an implementation for the generation of the jdkFeature event.