Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean metadata handler for attach command #1584

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Dec 11, 2024

What this PR does / why we need it:
This PR is a follow-up of #1578 with minor code change in attach metadata handler.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (53247dd) to head (90c796c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   84.33%   84.29%   -0.04%     
==========================================
  Files         120      120              
  Lines        5413     5413              
==========================================
- Hits         4565     4563       -2     
- Misses        602      604       +2     
  Partials      246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah changed the title chore: code clean chore: clean metadata handler for attach command Dec 11, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

cmd/oras/internal/display/metadata/text/attach.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah merged commit 6fe0395 into oras-project:main Dec 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants