Minor cleanup for 3.2.x, related to previous 3.1.x merges #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removal of unneeded call (todo) in OgnlRuntime.invokeMethod() since the SecurityManager sandbox logic has been merged from 3.1.x to 3.2.x. Same logic as in 3.1.x. - Avoid extra getModifiers() call in OgnlRuntime.setFieldValue(), same logic as in 3.1.x.
|
Hello OGNL Team. Noticed two minor items for 3.2.x during a review of another PR. If anyone notices any other minor cleanup items that could be added, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup fix:
SecurityManager sandbox logic has been merged from 3.1.x to 3.2.x. Same
logic as in 3.1.x.
logic as in 3.1.x.