Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-4817 Makes better decisions on methods first call #36

Merged
merged 1 commit into from
Aug 1, 2017
Merged

WW-4817 Makes better decisions on methods first call #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<groupId>ognl</groupId>
<artifactId>ognl</artifactId>
<packaging>jar</packaging>
<version>3.1.14</version>
<version>3.1.15-SNAPSHOT</version>
<name>OGNL - Object Graph Navigation Library</name>
<description>OGNL - Object Graph Navigation Library</description>

Expand Down
65 changes: 35 additions & 30 deletions src/java/ognl/OgnlRuntime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,21 +825,48 @@ public static Object invokeMethod(Object target, Method method, Object[] argsArr
// only synchronize method invocation if it actually requires it

synchronized(method) {
if (_methodAccessCache.get(method) == null
|| _methodAccessCache.get(method) == Boolean.TRUE) {
if (_methodAccessCache.get(method) == null) {
if (!Modifier.isPublic(method.getModifiers()) || !Modifier.isPublic(method.getDeclaringClass().getModifiers()))
{
if (!(((AccessibleObject) method).isAccessible()))
{
_methodAccessCache.put(method, Boolean.TRUE);
} else
{
_methodAccessCache.put(method, Boolean.FALSE);
}
} else
{
_methodAccessCache.put(method, Boolean.FALSE);
}
}
if (_methodAccessCache.get(method) == Boolean.TRUE) {
syncInvoke = true;
}

if (_securityManager != null && _methodPermCache.get(method) == null
|| _methodPermCache.get(method) == Boolean.FALSE) {
if (_methodPermCache.get(method) == null) {
if (_securityManager != null) {
try
{
_securityManager.checkPermission(getPermission(method));
_methodPermCache.put(method, Boolean.TRUE);
} catch (SecurityException ex) {
_methodPermCache.put(method, Boolean.FALSE);
throw new IllegalAccessException("Method [" + method + "] cannot be accessed.");
}
}
else {
_methodPermCache.put(method, Boolean.TRUE);
}
}
if (_methodPermCache.get(method) == Boolean.FALSE) {
checkPermission = true;
}
}

Object result;
boolean wasAccessible = true;

if (syncInvoke)
if (syncInvoke) //if is not public and is not accessible
{
synchronized(method)
{
Expand All @@ -848,34 +875,14 @@ public static Object invokeMethod(Object target, Method method, Object[] argsArr
try
{
_securityManager.checkPermission(getPermission(method));
_methodPermCache.put(method, Boolean.TRUE);
} catch (SecurityException ex) {
_methodPermCache.put(method, Boolean.FALSE);
throw new IllegalAccessException("Method [" + method + "] cannot be accessed.");
}
}

if (!Modifier.isPublic(method.getModifiers()) || !Modifier.isPublic(method.getDeclaringClass().getModifiers()))
{
if (!(wasAccessible = ((AccessibleObject) method).isAccessible()))
{
((AccessibleObject) method).setAccessible(true);
_methodAccessCache.put(method, Boolean.TRUE);
} else
{
_methodAccessCache.put(method, Boolean.FALSE);
}
} else
{
_methodAccessCache.put(method, Boolean.FALSE);
}

((AccessibleObject) method).setAccessible(true);
result = method.invoke(target, argsArray);

if (!wasAccessible)
{
((AccessibleObject) method).setAccessible(false);
}
((AccessibleObject) method).setAccessible(false);
}
} else
{
Expand All @@ -884,9 +891,7 @@ public static Object invokeMethod(Object target, Method method, Object[] argsArr
try
{
_securityManager.checkPermission(getPermission(method));
_methodPermCache.put(method, Boolean.TRUE);
} catch (SecurityException ex) {
_methodPermCache.put(method, Boolean.FALSE);
throw new IllegalAccessException("Method [" + method + "] cannot be accessed.");
}
}
Expand Down