-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache clearing enhancement (clear additional cache, synchronization fix): #77
Cache clearing enhancement (clear additional cache, synchronization fix): #77
Conversation
- Add a clearAdditionalCache() method to clear some additional cache elements. Using a separate method as changing the behaviour of clearCache() could negatively impact existing usage. - Added missing synchronization within clearCache() for many elements that should have synchronization for modifications.
- Added guard to avoid error output for matching score methods where one is abstract and the other concrete. Either method works when called, so the error output isn't needed for that specific condition (confirmed via manual debugging to force usage of both abstract and concrete method call). - Added test based on issue orphan-oss#42 which shows the syserr output is no longer produced for this scenario.
Hello OGNL Team. After reviewing open issues, decided to try to replicate issue #42 and was able to confirm that it still exists. A new test confirmed the syserr output was occurring for the reported scenario but the actual call by OGNL worked just fine. Looking at the code and "forcing both paths" (abstract and concrete) the proper result was returned in both cases. So the |
I also encountered some weird behaviour for some of the Security Sandbox tests when performing interactive debugging for the last update to this PR. Occasionally one of the sandbox tests Running the test module outside of the debugger never produced failures, so it's unclear if it was just interference by the IDE debugger or some underlying condition in the logic. Just wanted to leave a note for future reference in case an issue pops up. |
- Lukasz indicated he approved the JPMS package name "ognl". - Added the Automatic-Module-Name manifest-entry for this.
@JCgH4164838Gh792C124B5 conflict :( |
…calOGNL_3_1_ClearCacheEnh # Conflicts: # src/java/ognl/OgnlRuntime.java - Manually resolved merge conflict for OgnlRuntime.java
Hello @lukaszlenart . Manual resolution of merge conflicts completed (but might conflict if #75 is accepted/merged). It should be easier for others to review now, at least. 😄 |
LGTM 👍 |
…L_3_1_ClearCacheEnh Cache clearing enhancement (clear additional cache, synchronization fix): (cherry picked from commit 74f857c)
Attempt to resolve issue #34:
Using a separate method as changing the behaviour of clearCache() could negatively impact existing usage.