-
Notifications
You must be signed in to change notification settings - Fork 244
Add dialog open method from https://github.com/prestonhale/slacker/ fixed by jahirfiquitiva #134
base: master
Are you sure you want to change the base?
Conversation
If anybody is interested here was my workaround: I extended the class: And included it with extend_slacker.py
|
@@ -47,6 +46,7 @@ def __init__(self, body): | |||
self.body = json.loads(body) | |||
self.successful = self.body['ok'] | |||
self.error = self.body.get('error') | |||
self.message = self.body.get('response_metadata', {}).get('messages') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this line as it's not a part of this PR? There's another PR addressing this.
@@ -20,7 +20,6 @@ | |||
|
|||
from slacker.utils import get_item_id_by_name | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this line as well?
raise Error(response.error) | ||
error = response.error | ||
if response.message: | ||
error = "{error}: {response.message}" | ||
raise Error(error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this section as it's not directly related to this PR? Although I'm not a big fan of this as I want to keep the implementation as close as the original API as possible.
'unreads' : int(unreads) | ||
'unreads': int(unreads) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🍰 Thanks.
Please merge it if building not fails