Changed handling of object attributes in flex output #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joto
force-pushed
the
new-attr-handling
branch
from
dce55a4 to
ed27806
Compare
I did some benchmarking and it turns out there is real no measurable difference between putting the data in there and not doing it. So we'll just always do it. This means that it doesn't depend on the -x/--extra-attributes command line option any more. Note that the attributes will still be nil when coming from the middle in update mode if -x/--extra-attributes was not used on import.
This happens regardless of whether the -x/--extra-attributes option is set.
joto
force-pushed
the
new-attr-handling
branch
from
ed27806 to
daac353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards incompatible change in the way we are handling objects attributes (version, timestamp, changeset, uid, user) and the -x/--extra-attributes option in the flex output. The pgsql output is unaffected.
Old behaviour:
New behaviour:
process_node|way|relationfunctions. There are new functionsprocess_untagged_node|way|relationthat are always called for untagged objects if they are defined.This separates out the three concerns (availability of attributes in Lua config, handling of untagged objects, and storage of attributes in middle).
Fixes #1680
Fixes #189