-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recent setup failures. #102
base: develop
Are you sure you want to change the base?
Conversation
Fix changes to the build process that reflect a change in the way that the Chef cookbook uses the path and the way that setuptools is installed.
Note: if you want to test this locally, make sure you change the "revision" in ganeti_webmgr/chef/environments/vagrant.json to this branch, otherwise it will keep checking out the old version of the scripts and failing. |
Vagrantfile
Outdated
|
||
Vagrant.configure("2") do |config| | ||
config.vm.hostname = "gwm.example.org" | ||
config.vm.box = "centos-6-#{box_ver}" | ||
config.vm.box = "#{box_url}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well just replace this with 'bento/centos-6.8'
.
Vagrantfile
Outdated
config.vm.box = "centos-6-#{box_ver}" | ||
config.vm.box_url = "#{box_url}" | ||
config.vm.box = "bento/centos-6.8" | ||
config.vm.box_url = "bento/centos-6.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed, the box above will automatically get it's url populated.
@LyonesGamer how are you getting this to work? I keep running into berkshelf/vagrant-berkshelf#315. Perhaps it might make more sense to switch this over to running inside of docker? I'm not sure how much additional work that might be however but this seems to be an issue. @Kennric thoughts? |
@ramereth I'm not sure, I haven't seen that error myself. I just followed this guide: http://ganeti-webmgr.readthedocs.io/en/latest/dev/vagrant.html |
@LyonesGamer are you running this on one of our workstations with chefdk installed? |
@ramereth Yes. Does that make a difference? |
Setuptools v34 introduced several new dependencies, which must each themselves be installed with setuptools, creating a cyclic dependency that makes the whole thing very difficult to install. In order to fix this, pip is first upgraded to the newest versions (which are smart enough to know not to call setuptools on itself now), then the dependencies for setuptools are installed using the old version of setuptools, then setuptools itself is updated. This prevents any further issues.
As well, there was an issue with changes to the application (namely to the setup.sh script) not being reflected on the vagrant instance I was using for testing. This was because Chef was installing the application to /opt/ganeti_webmgr_src, but the setup script was told to use /home/vagrant/ganeti_webmgr as the install directory. Once they were both back on the same page, this fixed the issue.
I don't believe any documentation change is necessary here, as it's a minor change to very internal workings.