Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local state in sidebar in embed mode #12058

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukasHirt
Copy link
Collaborator

Description

When embed mode is enabled, use local state instead of local storage in sidebar to prevent overlapping the content when the embed iframe is opened.

Related Issue

Motivation and Context

Content is visible when embed iframe is opened.

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: added unit tests
  • test case 2: open embed iframe while sidebar is opened in the "regular" app

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

When embed mode is enabled, use local state instead of local storage in sidebar to prevent overlapping the content when the embed iframe is opened.
@LukasHirt LukasHirt added the Type:Bug Something isn't working label Dec 27, 2024
@LukasHirt LukasHirt self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Sidebar is overlapping content of file picker ("Save as" / "Open")
1 participant