[nexus] Use retryable transactions more extensively #7212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finds spots where we use
transaction_async
and makes them usetransaction_retry_wrapper
instead.This means that under contention, we'll avoid wasting work, and can make use of CockroachDB's automated retry mechanisms.
Additionally, this PR adds a clippy lint to help future usage avoid the "non-retryable" transaction variant.
There are some use cases where avoiding retries is still reasonable: