[reconfigurator] Fix DatasetsEditor internal zpool,kind -> ID map #7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueprint zones don't contain explicit dataset IDs (yet; see #7214), so `DatasetsEditor` maintained an internal cache mapping `(zpool, kind) -> dataset ID`. However, that mapping is only unique for _in service_ datasets, and `DatasetsEditor` was erroneously trying to build it for _all_ datasets (both in-service and expunged). This PR adds a few property tests and fixes for the maintenance of this cache, and should ensure that we only try to maintain the "at most one dataset of a given kind on a given zpool" map for in-service datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprint zones don't contain explicit dataset IDs (yet; see #7214), so
DatasetsEditormaintained an internal cache mapping(zpool, kind) -> dataset ID. However, that mapping is only unique for in service datasets, andDatasetsEditorwas erroneously trying to build it for all datasets (both in-service and expunged).This PR adds a few property tests and fixes for the maintenance of this cache, and should ensure that we only try to maintain the "at most one dataset of a given kind on a given zpool" map for in-service datasets.