Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up "Zfs::ensure_filesystem" #7246

Merged
merged 18 commits into from
Dec 16, 2024
Merged

Clean up "Zfs::ensure_filesystem" #7246

merged 18 commits into from
Dec 16, 2024

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Dec 13, 2024

  • Moves arguments into a struct
  • Removes unused "do_format" argument
  • Renamed to "ensure_dataset"

Fixes #7237

@smklein smklein requested a review from jgallagher December 13, 2024 01:13
jgallagher
jgallagher approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this helps the call sites quite a lot, and extra handy that it let us discover an unnecessary arg.

illumos-utils/src/zfs.rs Outdated Show resolved Hide resolved
Base automatically changed from sluggish-datasets to main December 13, 2024 23:14
@smklein smklein enabled auto-merge (squash) December 16, 2024 18:48
@smklein smklein merged commit 7ff5a28 into main Dec 16, 2024
16 checks passed
@smklein smklein deleted the zfs-args branch December 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgallagher jgallagher jgallagher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor ZFS filesystem ensure arguments
2 participants
@smklein @jgallagher