$@ is unstable in all perl versions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$@ might be a true value when eval succeeded.
Added tests which prove it. Fixes: https://rt.cpan.org/Public/Bug/Display.html?id=120512
Fixes failing test which was added in previous commit.
t/basic.t ...................... 1/36
Failed test '$@ untouched'
at t/basic.t line 222.
got: 'another magic'
expected: 'magic'
Looks like you failed 1 test of 36.
pali
force-pushed
the
unstable-dollarat
branch
from
81ffe91 to
4f0f14b
Compare
|
Failing test should be fixed in new third commit. |
|
ping; can you review this (and also other) pull requests? |
|
Can somebody review this pull request? |
|
@karenetheridge: ping |
|
General comment: we need more reviewers for this pull request. Try::Tiny is at the very top of the cpan river and changes here will affect the entire ecosystem. There is a lot going on in this pull request so we must be extremely cautious. |
|
@karenetheridge So who could review this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation about $@.
Fixes: https://rt.cpan.org/Public/Bug/Display.html?id=120512