Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): define address for the aggregated public key #1608

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Nov 22, 2024

Description

when we merge public keys, we can get the resulting address.

@kehiy kehiy requested review from b00f, Ja7ad and alidevjimmy November 22, 2024 12:56
Copy link
Collaborator

@b00f b00f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alidevjimmy please review

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18%. Comparing base (86a8ba9) to head (786ff67).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   75.07%   76.18%   +1.11%     
==========================================
  Files         234      236       +2     
  Lines       12156    18243    +6087     
==========================================
+ Hits         9126    13899    +4773     
- Misses       2582     3884    +1302     
- Partials      448      460      +12     
---- 🚨 Try these New Features:

@b00f b00f changed the title feat(grpc): add address public key merge fix(grpc): define address for the aggregated public key Nov 24, 2024
@Ja7ad Ja7ad merged commit 6cdf20c into pactus-project:main Nov 25, 2024
12 checks passed
@kehiy kehiy deleted the feature/multi-sig branch November 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants