Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(grpc): fix linting issues for JSON-RPC and gRRC docs #1609

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

alidevjimmy
Copy link
Contributor

Description

This PR fixes JSON-RPC and gRPC markdown lint issues while generating docs from templates.

@alidevjimmy alidevjimmy requested a review from Ja7ad November 22, 2024 16:25
@alidevjimmy alidevjimmy changed the title fix jrpc and grpc doc lint fix(doc): jrpc and grpc doc lint Nov 22, 2024
@alidevjimmy alidevjimmy changed the title fix(doc): jrpc and grpc doc lint fix(docs): jrpc and grpc doc lint Nov 22, 2024
@Ja7ad Ja7ad requested a review from b00f November 22, 2024 16:26
@b00f b00f changed the title fix(docs): jrpc and grpc doc lint chore(docs): fix linting issues for JSON-RPC and gRRC docs Nov 24, 2024
@b00f b00f changed the title chore(docs): fix linting issues for JSON-RPC and gRRC docs docs(grpc): fix linting issues for JSON-RPC and gRRC docs Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18%. Comparing base (86a8ba9) to head (8cf6d40).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
+ Coverage   75.07%   76.18%   +1.10%     
==========================================
  Files         234      236       +2     
  Lines       12156    18243    +6087     
==========================================
+ Hits         9126    13898    +4772     
- Misses       2582     3884    +1302     
- Partials      448      461      +13     
---- 🚨 Try these New Features:

@Ja7ad
Copy link
Contributor

Ja7ad commented Nov 25, 2024

@alidevjimmy Please fix conflicts.

@alidevjimmy
Copy link
Contributor Author

@alidevjimmy Please fix conflicts.

Please check again.

@Ja7ad Ja7ad merged commit bba3df3 into pactus-project:main Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants