-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(grpc): fix linting issues for JSON-RPC and gRRC docs #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alidevjimmy
changed the title
fix jrpc and grpc doc lint
fix(doc): jrpc and grpc doc lint
Nov 22, 2024
alidevjimmy
changed the title
fix(doc): jrpc and grpc doc lint
fix(docs): jrpc and grpc doc lint
Nov 22, 2024
Ja7ad
approved these changes
Nov 22, 2024
b00f
approved these changes
Nov 24, 2024
b00f
changed the title
fix(docs): jrpc and grpc doc lint
chore(docs): fix linting issues for JSON-RPC and gRRC docs
Nov 24, 2024
b00f
changed the title
chore(docs): fix linting issues for JSON-RPC and gRRC docs
docs(grpc): fix linting issues for JSON-RPC and gRRC docs
Nov 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
+ Coverage 75.07% 76.18% +1.10%
==========================================
Files 234 236 +2
Lines 12156 18243 +6087
==========================================
+ Hits 9126 13898 +4772
- Misses 2582 3884 +1302
- Partials 448 461 +13
|
@alidevjimmy Please fix conflicts. |
Please check again. |
Ja7ad
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes JSON-RPC and gRPC markdown lint issues while generating docs from templates.